From 4903d0b9dde8ab760b49aa410ff0a1d3eb05a6b4 Mon Sep 17 00:00:00 2001
From: Michael Dietz <mjdietzx@gmail.com>
Date: Tue, 16 Feb 2016 13:08:00 +0100
Subject: [PATCH] DFU Revision Characteristic is not being used optimally.

---
 dist/dfu.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/dist/dfu.js b/dist/dfu.js
index 4857b74..e10fcd1 100644
--- a/dist/dfu.js
+++ b/dist/dfu.js
@@ -122,16 +122,18 @@
 
             connect(device)
             .then(chars => {
+                // Older DFU implementations (from older Nordic SDKs < 7.0) have no DFU Version characteristic.
                 if (chars.versionChar) {
                     return chars.versionChar.readValue()
                     .then(data => {
+                        console.log('read versionChar');
                         var view = new DataView(data);
                         var major = view.getUint8(0);
                         var minor = view.getUint8(1);
                         return transfer(chars, arrayBuffer, imageType, major, minor);
                     });
                 } else {
-                    // Default to version 6.0
+                    // Default to version 6.0 (mbed).
                     return transfer(chars, arrayBuffer, imageType, 6, 0);
                 }
             })
@@ -183,12 +185,14 @@
                 log("found packet characteristic");
                 packetChar = characteristic;
                 service.getCharacteristic(versionUUID)
-                .then(characteristic => {
+                .then(characteristic => { // Older DFU implementations (from older Nordic SDKs) have no DFU Version characteristic. So this may fail.
                     log("found version characteristic");
                     versionChar = characteristic;
                     complete();
                 })
                 .catch(error => {
+                    error += ' no version charactersitic found';
+                    log(error);
                     complete();
                 });
             })