diff --git a/Redirector/EventHandler.cpp b/Redirector/EventHandler.cpp index 6c0c96eb..a017a934 100644 --- a/Redirector/EventHandler.cpp +++ b/Redirector/EventHandler.cpp @@ -56,7 +56,7 @@ wstring GetProcessName(DWORD id) return name; } -BOOL checkBypassName(DWORD id) +bool checkBypassName(DWORD id) { auto name = GetProcessName(id); @@ -64,14 +64,14 @@ BOOL checkBypassName(DWORD id) { if (regex_search(name, wregex(bypassList[i]))) { - return TRUE; + return true; } } - return FALSE; + return false; } -BOOL checkHandleName(DWORD id) +bool checkHandleName(DWORD id) { auto name = GetProcessName(id); @@ -79,11 +79,11 @@ BOOL checkHandleName(DWORD id) { if (regex_search(name, wregex(handleList[i]))) { - return TRUE; + return true; } } - return FALSE; + return false; } bool eh_init() diff --git a/Redirector/SocksHelper.cpp b/Redirector/SocksHelper.cpp index 7112c529..0a4fee5d 100644 --- a/Redirector/SocksHelper.cpp +++ b/Redirector/SocksHelper.cpp @@ -10,10 +10,10 @@ extern string tgtPassword; SOCKET SocksHelper::Utils::Connect() { auto client = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP); - if (!client) + if (client == INVALID_SOCKET) { printf("[Redirector][SocksHelper::Utils::Connect] Create socket failed: %d\n", WSAGetLastError()); - return NULL; + return INVALID_SOCKET; } { @@ -23,7 +23,7 @@ SOCKET SocksHelper::Utils::Connect() printf("[Redirector][SocksHelper::Utils::Connect] Set socket option failed: %d\n", WSAGetLastError()); closesocket(client); - return NULL; + return INVALID_SOCKET; } } @@ -35,7 +35,7 @@ SOCKET SocksHelper::Utils::Connect() printf("[Redirector][SocksHelper::Utils::Connect] Connect to remote server failed: %d\n", WSAGetLastError()); closesocket(client); - return NULL; + return INVALID_SOCKET; } return client; @@ -174,10 +174,10 @@ SocksHelper::TCP::TCP(SOCKET tcpSocket) SocksHelper::TCP::~TCP() { - if (this->tcpSocket) + if (this->tcpSocket != INVALID_SOCKET) { closesocket(this->tcpSocket); - this->tcpSocket = NULL; + this->tcpSocket = INVALID_SOCKET; } } @@ -240,7 +240,7 @@ bool SocksHelper::TCP::Connect(PSOCKADDR target) int SocksHelper::TCP::Send(char* buffer, int length) { - if (this->tcpSocket) + if (this->tcpSocket != INVALID_SOCKET) { return send(this->tcpSocket, buffer, length, 0); } @@ -250,7 +250,7 @@ int SocksHelper::TCP::Send(char* buffer, int length) int SocksHelper::TCP::Read(char* buffer, int length) { - if (this->tcpSocket) + if (this->tcpSocket != INVALID_SOCKET) { return recv(this->tcpSocket, buffer, length, 0); } @@ -269,16 +269,16 @@ SocksHelper::UDP::UDP(SOCKET tcpSocket) SocksHelper::UDP::~UDP() { - if (this->tcpSocket) + if (this->tcpSocket != INVALID_SOCKET) { closesocket(this->tcpSocket); - this->tcpSocket = NULL; + this->tcpSocket = INVALID_SOCKET; } - if (this->udpSocket) + if (this->udpSocket != INVALID_SOCKET) { closesocket(this->udpSocket); - this->udpSocket = NULL; + this->udpSocket = INVALID_SOCKET; } if (this->tcpThread.joinable()) @@ -289,7 +289,7 @@ SocksHelper::UDP::~UDP() bool SocksHelper::UDP::Associate() { - if (!this->tcpSocket) + if (this->tcpSocket == INVALID_SOCKET) { return false; } @@ -332,7 +332,7 @@ bool SocksHelper::UDP::CreateUDP() if (this->address.sin6_family == AF_INET6) { this->udpSocket = socket(AF_INET6, SOCK_DGRAM, IPPROTO_UDP); - if (!this->udpSocket) + if (this->udpSocket == INVALID_SOCKET) { printf("[Redirector][SocksHelper::UDP::CreateUDP] Create IPv6 socket failed: %d\n", WSAGetLastError()); return false; @@ -351,7 +351,7 @@ bool SocksHelper::UDP::CreateUDP() else { this->udpSocket = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP); - if (!this->udpSocket) + if (this->udpSocket == INVALID_SOCKET) { printf("[Redirector][SocksHelper::UDP::CreateUDP] Create IPv4 socket failed: %d\n", WSAGetLastError()); return false; @@ -373,7 +373,7 @@ bool SocksHelper::UDP::CreateUDP() int SocksHelper::UDP::Send(PSOCKADDR target, char* buffer, int length) { - if (!this->udpSocket) + if (this->udpSocket == INVALID_SOCKET) { return -1; } @@ -411,7 +411,7 @@ int SocksHelper::UDP::Send(PSOCKADDR target, char* buffer, int length) delete[] data; printf("[Redirector][SocksHelper::UDP::Send] Send packet failed: %d\n", WSAGetLastError()); - return 0; + return -1; } delete[] data; @@ -432,7 +432,7 @@ int SocksHelper::UDP::Read(PSOCKADDR target, char* buffer, int length) if (bufferLength == SOCKET_ERROR) { printf("[Redirector][SocksHelper::UDP::Read] Receive packet failed: %d\n", WSAGetLastError()); - return 0; + return -1; } return 0; diff --git a/Redirector/SocksHelper.h b/Redirector/SocksHelper.h index 0f01129f..75b8f60c 100644 --- a/Redirector/SocksHelper.h +++ b/Redirector/SocksHelper.h @@ -9,7 +9,6 @@ namespace SocksHelper { SOCKET Connect(); bool Handshake(SOCKET client); - bool ReadAddr(SOCKET client, char type, PSOCKADDR addr); } diff --git a/Redirector/TCPHandler.cpp b/Redirector/TCPHandler.cpp index adbf985f..7a6a8071 100644 --- a/Redirector/TCPHandler.cpp +++ b/Redirector/TCPHandler.cpp @@ -1,6 +1,6 @@ #include "TCPHandler.h" -SOCKET tcpSocket = NULL; +SOCKET tcpSocket = INVALID_SOCKET; USHORT tcpListen = 0; mutex tcpLock; @@ -17,7 +17,7 @@ bool TCPHandler::Init() } auto client = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP); - if (!client) + if (client == INVALID_SOCKET) { printf("[Redirector][TCPHandler::Init] Create socket failed: %d\n", WSAGetLastError()); return false; @@ -79,10 +79,10 @@ void TCPHandler::Free() { auto lg = lock_guard(tcpLock); - if (tcpSocket) + if (tcpSocket != INVALID_SOCKET) { closesocket(tcpSocket); - tcpSocket = NULL; + tcpSocket = INVALID_SOCKET; } tcpListen = 0; @@ -115,10 +115,10 @@ void TCPHandler::DeleteHandler(SOCKADDR_IN6 client) void TCPHandler::Accept() { - while (tcpSocket) + while (tcpSocket != INVALID_SOCKET) { auto client = accept(tcpSocket, NULL, NULL); - if (!client) + if (client == INVALID_SOCKET) { return; } @@ -143,7 +143,7 @@ void TCPHandler::Handle(SOCKET client) } auto remote = SocksHelper::Utils::Connect(); - if (!remote) + if (remote != INVALID_SOCKET) { closesocket(client); return; @@ -189,10 +189,10 @@ void TCPHandler::Read(SOCKET client, SocksHelper::PTCP remote) { char buffer[1446]; - while (tcpSocket) + while (tcpSocket != INVALID_SOCKET) { auto length = remote->Read(buffer, 1446); - if (!length) + if (!length || length == SOCKET_ERROR) { return; } @@ -208,10 +208,10 @@ void TCPHandler::Send(SOCKET client, SocksHelper::PTCP remote) { char buffer[1446]; - while (tcpSocket) + while (tcpSocket != INVALID_SOCKET) { auto length = recv(client, buffer, 1446, 0); - if (!length) + if (!length || length == SOCKET_ERROR) { return; }