diff --git a/BetterGenshinImpact/View/Pages/CommonSettingsPage.xaml b/BetterGenshinImpact/View/Pages/CommonSettingsPage.xaml
index 893b5342..d7108119 100644
--- a/BetterGenshinImpact/View/Pages/CommonSettingsPage.xaml
+++ b/BetterGenshinImpact/View/Pages/CommonSettingsPage.xaml
@@ -860,11 +860,77 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@ -890,7 +956,6 @@
Margin="0,0,36,0"
IsChecked="{Binding Config.OtherConfig.RestoreFocusOnLostEnabled, Mode=TwoWay}" />
-
diff --git a/BetterGenshinImpact/View/Pages/TaskSettingsPage.xaml b/BetterGenshinImpact/View/Pages/TaskSettingsPage.xaml
index 1ccf786d..0113c1e6 100644
--- a/BetterGenshinImpact/View/Pages/TaskSettingsPage.xaml
+++ b/BetterGenshinImpact/View/Pages/TaskSettingsPage.xaml
@@ -1576,72 +1576,6 @@
DisplayMemberPath="Value"
SelectedItem="{Binding Config.AutoFishingConfig.FishingTimePolicy, Converter={StaticResource EnumToKVPConverter}, Mode=TwoWay}" />
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs b/BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs
index 064dbfd9..1c3812d6 100644
--- a/BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs
+++ b/BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs
@@ -1,10 +1,16 @@
+using System;
+using System.Collections.Frozen;
+using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Diagnostics;
+using System.Globalization;
using System.IO;
using System.IO.Compression;
using System.Linq;
+using System.Threading.Tasks;
using System.Windows;
using BetterGenshinImpact.Core.Config;
+using BetterGenshinImpact.Core.Recognition.OCR;
using BetterGenshinImpact.Core.Script;
using BetterGenshinImpact.GameTask;
using BetterGenshinImpact.GameTask.AutoTrackPath;
@@ -12,11 +18,14 @@ using BetterGenshinImpact.GameTask.Common.Element.Assets;
using BetterGenshinImpact.Helpers;
using BetterGenshinImpact.Service.Interface;
using BetterGenshinImpact.Service.Notification;
+using BetterGenshinImpact.View.Converters;
using BetterGenshinImpact.View.Pages;
using BetterGenshinImpact.View.Windows;
+using CommunityToolkit.Mvvm.ComponentModel;
using CommunityToolkit.Mvvm.Input;
using CommunityToolkit.Mvvm.Messaging;
using CommunityToolkit.Mvvm.Messaging.Messages;
+using Microsoft.Extensions.Localization;
using Microsoft.Win32;
using Wpf.Ui;
@@ -47,6 +56,18 @@ public partial class CommonSettingsPageViewModel : ViewModel
public ObservableCollection CountryList { get; } = new();
public ObservableCollection Areas { get; } = new();
+ [ObservableProperty]
+ private FrozenDictionary _languageDict = new string[] { "zh-Hans", "zh-Hant", "en", "fr" }
+ .ToFrozenDictionary(
+ c => c,
+ c =>
+ {
+ CultureInfo.CurrentUICulture = new CultureInfo(c);
+ var stringLocalizer = App.GetService>() ?? throw new NullReferenceException();
+ return stringLocalizer["简体中文"].ToString();
+ }
+ );
+
public string SelectedCountry
{
get => _selectedCountry;
@@ -232,4 +253,10 @@ public partial class CommonSettingsPageViewModel : ViewModel
keyBindingsWindow.Owner = Application.Current.MainWindow;
keyBindingsWindow.ShowDialog();
}
+
+ [RelayCommand]
+ private async Task OnGameLangSelectionChanged(KeyValuePair type)
+ {
+ await OcrFactory.ChangeCulture(type.Key);
+ }
}
\ No newline at end of file
diff --git a/BetterGenshinImpact/ViewModel/Pages/TaskSettingsPageViewModel.cs b/BetterGenshinImpact/ViewModel/Pages/TaskSettingsPageViewModel.cs
index 2b4336f3..6ccf9666 100644
--- a/BetterGenshinImpact/ViewModel/Pages/TaskSettingsPageViewModel.cs
+++ b/BetterGenshinImpact/ViewModel/Pages/TaskSettingsPageViewModel.cs
@@ -16,7 +16,6 @@ using CommunityToolkit.Mvvm.Input;
using System;
using System.Collections.Generic;
using System.ComponentModel;
-using System.Diagnostics;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
@@ -31,12 +30,7 @@ using Wpf.Ui.Violeta.Controls;
using BetterGenshinImpact.ViewModel.Pages.View;
using System.Linq;
using System.Reflection;
-using Vanara.Extensions;
using System.Collections.Frozen;
-using System.Globalization;
-using Microsoft.Extensions.Localization;
-using BetterGenshinImpact.View.Converters;
-using BetterGenshinImpact.Core.Recognition.OCR;
namespace BetterGenshinImpact.ViewModel.Pages;
@@ -134,18 +128,6 @@ public partial class TaskSettingsPageViewModel : ViewModel
.GetCustomAttribute()?
.Description ?? e.ToString());
- [ObservableProperty]
- private FrozenDictionary _languageDict = new string[] { "zh-Hans", "zh-Hant", "en", "fr" }
- .ToFrozenDictionary(
- c => c,
- c =>
- {
- CultureInfo.CurrentUICulture = new CultureInfo(c);
- var stringLocalizer = App.GetService>() ?? throw new NullReferenceException();
- return stringLocalizer["简体中文"].ToString();
- }
- );
-
private bool saveScreenshotOnKeyTick;
public bool SaveScreenshotOnKeyTick
{
@@ -434,10 +416,4 @@ public partial class TaskSettingsPageViewModel : ViewModel
{
_autoFightViewModel.OnOpenLocalScriptRepo();
}
-
- [RelayCommand]
- private async Task OnGameLangSelectionChanged(KeyValuePair type)
- {
- await OcrFactory.ChangeCulture(type.Key);
- }
}
\ No newline at end of file